org.guifications.plugins: fdacb939f6a59356f60e8fdd30a535af82956489

[nosnilmot at guifications.org]

-----------------------------------------------------------------
Revision: fdacb939f6a59356f60e8fdd30a535af82956489
Ancestor: b68d98afb2c565ccfe16c02aecd2961c2515d1b3
Author: nosnilmot at guifications.org
Date: 2008-03-13T01:18:03
Branch: org.guifications.plugins

Modified files:
        irchelper/irchelper.c

ChangeLog: 

Potential leak fix (use with other plugins can leak)

-----------------------------------------------------------------
This revision's diffstat output:
 irchelper.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
-------------- next part --------------
============================================================
--- irchelper/irchelper.c	d835ad297d173931bba3998e1cbf748c1346e633
+++ irchelper/irchelper.c	9a813bbd5e33f23af90d36f13ce1d4d1f999e74d
@@ -199,7 +199,12 @@ static PurpleConversation *get_conversat
 
 	conv = g_new0(PurpleConversation, 1);
 	conv->type = PURPLE_CONV_TYPE_IM;
-	purple_conversation_set_account(conv, account);
+	/* If we use this then the conversation updated signal is fired and
+	 * other plugins might start doing things to our conversation, such as
+	 * setting data on it which we would then need to free etc. It's easier
+	 * just to be more hacky by setting account directly. */
+	/* purple_conversation_set_account(conv, account); */
+	conv->account = account;
 
 	return conv;
 }