[Pidgin Plugins] #438: Timelog build issues

[Pidgin Plugins]

#438: Timelog build issues
------------------------+---------------------------------------------------
 Reporter:  rageboy04   |       Owner:                 
     Type:  Bugs        |      Status:  new            
 Priority:  4           |   Milestone:  PluginPack2.3.0
Component:  PluginPack  |     Version:  PluginPack2.2.0
 Keywords:              |     Pending:  0              
------------------------+---------------------------------------------------
 well, it seemed to create a dll anyway, but I got some warnings and
 errors:


 {{{
 gcc.exe -O2 -Wall -Waggregate-return -Wcast-align -Wdeclaration-after-
 statement -Werror-implicit-function-declaration -Wextra -Wno-sign-compare
 -Wno-unused-parameter -Winit-self -Wmissing-declarations -Wmissing-
 prototypes -Wnested-externs -Wpointer-arith -Wundef -pipe -mno-cygwin
 -mms-bitfields -g -I. -I../../../../../win32-dev/gtk_2_0/include
 -I../../../../../win32-dev/gtk_2_0/include/gtk-2.0
 -I../../../../../win32-dev/gtk_2_0/include/glib-2.0
 -I../../../../../win32-dev/gtk_2_0/include/pango-1.0
 -I../../../../../win32-dev/gtk_2_0/include/atk-1.0
 -I../../../../../win32-dev/gtk_2_0/include/freetype2
 -I../../../../../win32-dev/gtk_2_0/lib/glib-2.0/include
 -I../../../../../win32-dev/gtk_2_0/lib/gtk-2.0/include
 -I../../../../libpurple -I../../../../libpurple/win32 -I../../../../pidgin
 -I../../../../pidgin/win32 -I../../../.. -DHAVE_CONFIG_H
 -DPP_VERSION=\"2.3.0mtn\" -c log-widget.c -o log-widget.o
 gcc.exe -O2 -Wall -Waggregate-return -Wcast-align -Wdeclaration-after-
 statement -Werror-implicit-function-declaration -Wextra -Wno-sign-compare
 -Wno-unused-parameter -Winit-self -Wmissing-declarations -Wmissing-
 prototypes -Wnested-externs -Wpointer-arith -Wundef -pipe -mno-cygwin
 -mms-bitfields -g -I. -I../../../../../win32-dev/gtk_2_0/include
 -I../../../../../win32-dev/gtk_2_0/include/gtk-2.0
 -I../../../../../win32-dev/gtk_2_0/include/glib-2.0
 -I../../../../../win32-dev/gtk_2_0/include/pango-1.0
 -I../../../../../win32-dev/gtk_2_0/include/atk-1.0
 -I../../../../../win32-dev/gtk_2_0/include/freetype2
 -I../../../../../win32-dev/gtk_2_0/lib/glib-2.0/include
 -I../../../../../win32-dev/gtk_2_0/lib/gtk-2.0/include
 -I../../../../libpurple -I../../../../libpurple/win32 -I../../../../pidgin
 -I../../../../pidgin/win32 -I../../../.. -DHAVE_CONFIG_H
 -DPP_VERSION=\"2.3.0mtn\" -c range-widget.c -o range-widget.o
 range-widget.c: In function `calendar_update':
 range-widget.c:74: warning: comparison of unsigned expression < 0 is
 always false
 range-widget.c: In function `cb_time_value_changed':
 range-widget.c:146: warning: ISO C90 forbids mixed declarations and code
 range-widget.c: At top level:
 range-widget.c:188: warning: no previous prototype for
 'range_widget_create'
 range-widget.c: In function `range_widget_create':
 range-widget.c:350: warning: ISO C90 forbids mixed declarations and code
 gcc.exe -O2 -Wall -Waggregate-return -Wcast-align -Wdeclaration-after-
 statement -Werror-implicit-function-declaration -Wextra -Wno-sign-compare
 -Wno-unused-parameter -Winit-self -Wmissing-declarations -Wmissing-
 prototypes -Wnested-externs -Wpointer-arith -Wundef -pipe -mno-cygwin
 -mms-bitfields -g -I. -I../../../../../win32-dev/gtk_2_0/include
 -I../../../../../win32-dev/gtk_2_0/include/gtk-2.0
 -I../../../../../win32-dev/gtk_2_0/include/glib-2.0
 -I../../../../../win32-dev/gtk_2_0/include/pango-1.0
 -I../../../../../win32-dev/gtk_2_0/include/atk-1.0
 -I../../../../../win32-dev/gtk_2_0/include/freetype2
 -I../../../../../win32-dev/gtk_2_0/lib/glib-2.0/include
 -I../../../../../win32-dev/gtk_2_0/lib/gtk-2.0/include
 -I../../../../libpurple -I../../../../libpurple/win32 -I../../../../pidgin
 -I../../../../pidgin/win32 -I../../../.. -DHAVE_CONFIG_H
 -DPP_VERSION=\"2.3.0mtn\" -c timelog.c -o timelog.o
 timelog.c:185: warning: missing initializer
 timelog.c:185: warning: (near initialization for `info._purple_reserved1')
 gcc.exe -shared log-widget.o log-widget.h range-widget.o range-widget.h
 timelog.o timelog.h -L../../../../../win32-dev/gtk_2_0/lib
 -L../../../../libpurple -L../../../../pidgin -lgtk-win32-2.0 -lgdk-
 win32-2.0 -lgdk_pixbuf-2.0 -lglib-2.0 -lpango-1.0 -lgmodule-2.0
 -lgobject-2.0 -lws2_32 -lintl -lpurple -lpidgin -Wl,--enable-auto-image-
 base -o timelog.dll
 log-widget.h:27: error: syntax error before '*' token
 range-widget.h:27: error: syntax error before '*' token
 range-widget.h:27: warning: data definition has no type or storage class
 range-widget.h:28: error: syntax error before '*' token
 range-widget.h:29: error: syntax error before '*' token
 make: *** [timelog.dll] Error 1
 }}}

 The syntax errors are because of lines like
 "void range_widget_get_bounds(GtkWidget *dialog, time_t *start, time_t
 *end);" without a "#include <gtk.h>" or whatever it is and "#include
 <glib.h>" in the other file. It shouldn't cause timelog to not work, but
 on Windows at least, timelog doesn't show up in the list of plugins in
 Pidgin 2.3.0.

-- 
Ticket URL: <http://plugins.guifications.org/trac/ticket/438>
Pidgin Plugins <http://pidgin.guifications.org/>
Plugins for the Instant Messaging client Pidgin and its backend library libpurple